Fix pVACview aggregate report header tooltips - #1463
Open
susannasiebert wants to merge 1 commit into
Open
Conversation
tmooney
approved these changes
Sep 9, 2026
tmooney
left a comment
tmooney
left a comment
Member
There was a problem hiding this comment.
+1, I'm trusting that these are now the correct columns 🙂
| " 'IC50 WT - IC50 binding affinity of the corresponding wildtype epitope.',", | ||
| paste(" '%ile MT - ", score_mode, "binding affinity percentile rank of the best-binding mutant epitope across all prediction algorithms used (those that provide percentile output).', "), | ||
| " '%ile WT - Binding affinity percentile rank of the corresponding wildtype epitope across all prediction algorithms used (those that provide percentile output).', ", | ||
| paste(" 'IC50 MT - ", score_mode, "IC50 binding affinity of the Best Peptide across all binding affinity prediction algorithms used.', "), |
Member
There was a problem hiding this comment.
It looks like these paste lines have a different number of leading spaces from the literal strings in this list. Is this intentional?
Contributor
Author
There was a problem hiding this comment.
I tested this change locally and it runs without issue so I don't think the number of spaces matters. I believe this is mainly done for human readability (I didn't write this originally so I'm not sure). I think the original intend was to maybe align all array entries with the first entry on line 14 but that no longer seems to be the case either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the changes made in v7.x to the aggregated report, we never updates the header tooltips when displaying this file in pVACview. This PR fixes that. It also fixes a few existing tooltips to better describe the contents of the column.