Preserve AttributeError exceptions from CLI commands - #1444
Draft
YT-er wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AttributeErrorraised by a selected command to propagate unchangedWhy
The broad
AttributeErrorhandler currently treats command implementation failures as if no command was provided. This masks the real exception and replaces it with generic help output.Impact
Invocations without a command retain the current help and exit behavior. Runtime
AttributeErrorexceptions from commands are no longer hidden.Validation
python -m unittest tests.test_cli_error_handling— 2 tests passed with all seven CLIs exercised as subtestsgit diff --checkpassedThis is one focused replacement for part of #1430 and is based on
8.0.0.AI assistance disclosure
This PR was AI-assisted using OpenAI Codex for implementation, test drafting, and command execution. I reviewed the diff line by line, ran the validation above, and take responsibility for the submitted changes.