Replace dynamic evaluation in filtering - #1442
Draft
YT-er wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eval()use in tabular filtering with an explicit operator mapWhy
Filter values originate in TSV data. Constructing and evaluating Python expressions from those values can execute unintended code and produces unclear failures for malformed input.
Impact
Valid numeric filters retain their existing behavior, including
NA, skipped values, andinf. Invalid operators and non-numeric values now fail deterministically.Validation
python -m unittest tests.test_filter— 13 tests passedgit diff --checkpassedThis is one focused replacement for part of #1430 and is based on
8.0.0.AI assistance disclosure
This PR was AI-assisted using OpenAI Codex for implementation, test drafting, and command execution. I reviewed the diff line by line, ran the validation above, and take responsibility for the submitted changes.