ci: replace buildkite pipeline with github actions - #136
Open
alexjoedt wants to merge 3 commits into
Open
Conversation
Run the existing ci_test, ci_build and ci_lint make targets as three jobs in a GitHub workflow on pull requests and pushes to master. The targets still run inside the gridx dev image, so the test environment stays the same. Remove the buildkite pipeline and the unused BRANCH variable in the Makefile. Claude-Session: https://claude.ai/code/session_01ABvNB1a6JTYe68AJYjduQ5
Anonymous pulls from public ECR are rate limited per IP, which makes the shared GitHub runners fail with "toomanyrequests". Add a manual workflow that mirrors the gridx dev image to ghcr.io/grid-x/modbus-dev and point the Makefile at that copy. Claude-Session: https://claude.ai/code/session_01ABvNB1a6JTYe68AJYjduQ5
workflow_dispatch only works once the file is on the default branch. Claude-Session: https://claude.ai/code/session_01ABvNB1a6JTYe68AJYjduQ5
Member
There was a problem hiding this comment.
Do we really need this file? Once the PR is merged, we will no longer publish to our ECR anyway, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the Buildkite pipeline with a GitHub workflow.
.github/workflows/ci.ymlwith three jobs: Tests, Build, Lint. Each one runs the existingci_test,ci_buildandci_lintmake target, so everything still runs inside the gridx dev image (Go 1.21, golint, diagslave, socat).toomanyrequestson the shared runners, so the image now comes fromghcr.io/grid-x/modbus-dev:go1.21. The newmirror-ci-image.ymlworkflow copies it there (already ran, same digest as the ECR image). It runs on changes to its own file and on manual dispatch, so bumping the default tag re-mirrors..buildkite/pipeline.yamland the unusedBRANCHvariable in the Makefile.All three jobs pass on this PR.
After merge:
Follow-up (separate PR): drop the dev image in favour of
actions/setup-goplus apt and a diagslave download, and replace the archived golint.