Add proto for Windows in discovery service - #69640
Conversation
danielashare
added
the
no-changelog
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 454c68dd5b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| HTTPProxySettings HTTPProxySettings = 11 [(gogoproto.jsontag) = "http_proxy_settings,omitempty"]; | ||
| // WindowsScriptName is the name of the teleport installer script resource for | ||
| // the cloud instance to execute on Windows. | ||
| string WindowsScriptName = 12 [(gogoproto.jsontag) = "windows_script_name,omitempty"]; |
There was a problem hiding this comment.
When this new install-param field (and the two below it) is changed on an existing DiscoveryConfig, the discovery service can treat the update as a no-op: api/types/discoveryconfig/derived.gen.go's deriveTeleportEqual_17 still compares only through HTTPProxySettings, and lib/srv/discovery/discovery.go skips matcher refreshes when oldDiscoveryConfig.IsEqual(dc). The Terraform discovery_config schema also still enumerates the old InstallerParams attributes, so plans cannot preserve these values; regenerate/update those helpers with the new fields.
AGENTS.md reference: AGENTS.md:L17-L17
Useful? React with 👍 / 👎.
454c68d to
6d68f85
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6d68f85a37
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
6d68f85 to
2f814c8
Compare
2 participants
This PR adds proto in support of adding Windows non-AD desktop discovery to the discovery service.
The changes to:
discoveryconfig.protoallow summaries of discovered VMs to be tracked and shown to uses.events.protoadds a field to theazure.runevent that specifies which type of VM was affected (nodeorwindows.auth-packge(slightly funny name for a first addition of a windows resource to this part of the codebase, but we'll soon have a windows agent which will be called something likewindows.agent)).types.protofor Windows specific settings during installation.Tracking Issue and RFD for the feature.
Manual Test Plan
Test Environment
This branch is split from a larger (+4,561, -2,613) branch that I didn't want to have people review, testing was done on that branch.
Test Cases