Fix request.reason.mode calcuation for glob and claims_to_roles expressions - #69629
Open
smallinsky wants to merge 3 commits into
Open
Fix request.reason.mode calcuation for glob and claims_to_roles expressions#69629smallinsky wants to merge 3 commits into
smallinsky wants to merge 3 commits into
Conversation
smallinsky
force-pushed
the
smallinksy/request-reson-fix
branch
from
August 13, 2026 09:54
3443159 to
b8954bf
Compare
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Contributor
Author
|
friendly ping @ryanclark @gabrielcorado |
kopiczko
approved these changes
Aug 14, 2026
smallinsky
force-pushed
the
smallinksy/request-reson-fix
branch
from
August 14, 2026 09:29
b8954bf to
58381f5
Compare
ryanclark
approved these changes
Aug 14, 2026
ryanclark
left a comment
Member
There was a problem hiding this comment.
I don't think we can merge today can we?
public-teleport-github-review-bot
Bot
removed the request for review
from gabrielcorado
August 14, 2026 11:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54397
Closes gravitational/customer-sensitive-requests#700
What
The
request.reason.mode: requiredforce a user to provide a Access Request Description. The option is configurable and make forces a JIT issuer to provided desc why he is requesting access.The current functionality was only checking literal value equlity instead of
regexpandclaims_to_rolesmatching rules.Why we match the
mode: requiredagainsregexporclaims_to_roles?This is needed because the the by default support regexp and claims_to_roles that and this cases where missing from intimal requested reason functionality:
https://goteleport.com/docs/identity-governance/access-requests/access-request-configuration/#requiring-request-reasons
changelog: Fixed access request reason requirement (request.reason.mode: required) being ignored when requestable roles were specified with a wildcard, regexp, or claims_to_roles instead of literal role names.
Manual Test Plan
Test Environment
local env
Test Cases
TODO: