Skip to content

Fix tsh/common test timeout by sharing kube cluster fixtures - #69625

Draft
jakealti wants to merge 5 commits into
masterfrom
jakealti/fix-tsh-test-timeout
Draft

Fix tsh/common test timeout by sharing kube cluster fixtures#69625
jakealti wants to merge 5 commits into
masterfrom
jakealti/fix-tsh-test-timeout

Conversation

@jakealti

@jakealti jakealti commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

The tests in tool/tsh/common were timing out in CI.

When a test changes, CI runs it 100 times to check for flakiness, and that job has
a 10 minute limit. TestKube and TestKubeLogin start three Teleport clusters
between them, and they did it on every one of the 100 runs.

Now the clusters are started once and reused. That in turn made every run share
one proxy, which then hit the rate limit on /webapi/ping/:connector, so the
proxy also takes an optional rate limiter config that the fixture sets to empty.
When the field is nil the proxy behaves exactly as before.

The flaky test job used to time out at 10 minutes. It now finishes in 136s.

Each commit stands on its own, so this is easier to review commit by commit.

@jakealti jakealti added no-changelog Indicates that a PR does not require a changelog entry no-test-plan Bypasses the test plan validation bot labels Aug 13, 2026
@jakealti
jakealti force-pushed the jakealti/fix-tsh-test-timeout branch from 3cf0fac to 64d72d2 Compare August 14, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Indicates that a PR does not require a changelog entry no-test-plan Bypasses the test plan validation bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant