Update Teleport version vars - #69581
Conversation
|
Amplify deployment status
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87dd75c85b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "teleport": { | ||
| "major_version": "18", | ||
| "version": "18.10.0", | ||
| "version": "18.10.4", |
There was a problem hiding this comment.
Split artifact version from source-link version
Because 18.10.4 is documented as a private security release, setting the global teleport.version to 18.10.4 also rewrites docs that use this variable for GitHub source URLs and raw file downloads, not just install artifacts. For example, docs/pages/configuration/teleport-operator/teleport-operator-standalone.mdx will render a raw.githubusercontent.com/gravitational/teleport/v18.10.4/... command, and the plugin/helm references render github.com/gravitational/teleport/tree/v18.10.4/...; those refs are not public during the private-release window, so readers hit broken links/commands even though the release binaries are available. Please keep source-code links on a public tag or add a separate variable for the private artifact version.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
I'd rather figure this one out from a position of having updating the version variable for the hot path, the many Teleport binary command snippets in the docs.
Reflect the 18.10.4 private security release.
87dd75c to
7454945
Compare
Reflect the 18.10.4 private security release.