Skip to content

fix: clarify external error messages #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghassan-gaidi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: clarify external error messages #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/conversation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ export class Conversation<
if (this.insideExternal) {
throw new Error(
"Cannot wait for updates from inside `external`, or concurrently to it! \
Bot API calls (e.g. ctx.api.*, ctx.reply) must not be made inside `external`. \
First return your data from `external` and then resume update handling using `wait` calls.",
);
}
Expand Down
6 changes: 5 additions & 1 deletion src/state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,11 @@ export function cursor(state: ReplayState): ReplayCursor {
// replay existing data (do nothing)
const expected = state.send[send].payload;
if (expected !== payload) {
throw new Error(`Bad replay, expected op '${expected}'`);
throw new Error(
`Bad replay, expected op '${expected}' but got '${payload}'. \
This usually means a Bot API call (e.g. ctx.api.*, ctx.reply) was made inside \
\`conversation.external()\` or the conversation was otherwise used incorrectly.`,
);
}
} else { // send === state.send.length
// log new data
Expand Down