Skip to content

MQE: info() derive info series @ reference only when the first argument's vector paths are uniform - #16497

Open
zenador wants to merge 3 commits into
mainfrom
zenador/mqe-info-func-fix-safely-derive
Open

MQE: info() derive info series @ reference only when the first argument's vector paths are uniform#16497
zenador wants to merge 3 commits into
mainfrom
zenador/mqe-info-func-fix-safely-derive

Conversation

@zenador

@zenador zenador commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

What this PR does

Restore MQE's feature parity with Prometheus for the info function, matching behaviour for tests defined upstream.

Which issue(s) this PR fixes or relates to

Refining the behaviour implemented in #16220

Implements prometheus/prometheus#19387 from upstream that was vendored in #16496

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]. If changelog entry is not needed, please add the changelog-not-needed label to the PR.
  • about-versioning.md updated with experimental features.

@zenador
zenador requested a review from a team as a code owner August 28, 2026 12:24

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7db6783. Configure here.

if !w.found {
return nil, 0, false
}
return w.first.timestamp, w.first.offset, w.uniform && !w.referenceFree

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-uniform info lookup still pins range

High Severity

infoSelectTimestampAndOffset now returns the first selector's @ timestamp and offset even when uniform is false, but infoSeriesQueriedTimeRange ignores that flag and still pins the info-series fetch window to those values. Mixed-reference info() queries then advertise a too-narrow queried range, so remote execution can omit evaluation-time info series and drop enrichment.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 7db6783. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant