Compactor: honor the per-tenant float chunk encoding - #16488
Draft
roidelapluie wants to merge 1 commit into
Draft
Conversation
The split-and-merge compactor built a single LeveledCompactor with no FloatChunkEncoding, so the merge function re-encoded overlapping float chunks as xor, undoing float_chunk_encoding=xor2 for the tenants that set it. Build one compactor per tenant instead, capturing the encoding as a constant so it cannot change mid-compaction. The metrics stay shared, so exported metrics are unchanged. The accepted values now come from a single table in pkg/util/validation, used by the flag default and help, the limit validation, the ingester and the overrides-exporter, which each had their own copy of the mapping. No behaviour change there. Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
roidelapluie
marked this pull request as draft
August 27, 2026 12:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The split-and-merge compactor built a single LeveledCompactor with no FloatChunkEncoding, so the merge function re-encoded overlapping float chunks as xor, undoing float_chunk_encoding=xor2 for the tenants that set it. Build one compactor per tenant instead, capturing the encoding as a constant so it cannot change mid-compaction. The metrics stay shared, so exported metrics are unchanged.
The accepted values now come from a single table in pkg/util/validation, used by the flag default and help, the limit validation, the ingester and the overrides-exporter, which each had their own copy of the mapping. No behaviour change there.
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.