Skip to content

Allow common storage prefix subpaths - #16479

Open
zazulam wants to merge 2 commits into
grafana:mainfrom
zazulam:zazulam-relax-storage-prefix-validation
Open

Allow common storage prefix subpaths#16479
zazulam wants to merge 2 commits into
grafana:mainfrom
zazulam:zazulam-relax-storage-prefix-validation

Conversation

@zazulam

@zazulam zazulam commented Aug 26, 2026

Copy link
Copy Markdown

What this PR does

Allows storage prefixes to use common bucket subpath patterns with /, -, and _, such as team-a/mimir_blocks. Leading, trailing, repeated, and overlapping parent/child prefixes remain invalid.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated.
  • about-versioning.md is not required; this is not an experimental feature.

Permit slash-separated storage prefixes whose path segments use common alphanumeric, hyphen, and underscore naming patterns.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@zazulam
zazulam requested review from a team as code owners August 26, 2026 12:45
@cla-assistant

cla-assistant Bot commented Aug 26, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 988b7fe. Configure here.

Comment thread pkg/storage/bucket/client.go
Prevent parent and child storage prefixes from sharing the blocks object namespace while allowing sibling subpaths.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant