Allow common storage prefix subpaths - #16479
Open
zazulam wants to merge 2 commits into
Open
Conversation
Permit slash-separated storage prefixes whose path segments use common alphanumeric, hyphen, and underscore naming patterns. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 988b7fe. Configure here.
Prevent parent and child storage prefixes from sharing the blocks object namespace while allowing sibling subpaths. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What this PR does
Allows storage prefixes to use common bucket subpath patterns with
/,-, and_, such asteam-a/mimir_blocks. Leading, trailing, repeated, and overlapping parent/child prefixes remain invalid.Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated.about-versioning.mdis not required; this is not an experimental feature.