Skip to content

fix(mimir): gate StrongConsistency alert on strong mode #16477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shoemoney wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −4
Open

fix(mimir): gate StrongConsistency alert on strong mode #16477

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18a9c98
fix(mimir): gate StrongConsistency alert on strong mode
shoemoney Aug 26, 2026
236f18b
fix(mimir): gate on total strong-consistency traffic, not offset-tagg…
shoemoney Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions operations/mimir-mixin/alerts/ingest-storage.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,10 +238,14 @@ local utils = import 'mixin-utils/utils.libsonnet';
alert: $.alertName('StrongConsistencyOffsetMissing'),
'for': '5m',
expr: |||
sum by (%(alert_aggregation_labels)s) (rate(cortex_ingest_storage_strong_consistency_requests_total{component="partition-reader", with_offset="false"}[%(range)s]))
/
sum by (%(alert_aggregation_labels)s) (rate(cortex_ingest_storage_strong_consistency_requests_total{component="partition-reader"}[%(range)s]))
* 100 > 5
(
sum by (%(alert_aggregation_labels)s) (rate(cortex_ingest_storage_strong_consistency_requests_total{component="partition-reader", with_offset="false"}[%(range)s]))
/
sum by (%(alert_aggregation_labels)s) (rate(cortex_ingest_storage_strong_consistency_requests_total{component="partition-reader"}[%(range)s]))
* 100 > 5
)
and
sum by (%(alert_aggregation_labels)s) (rate(cortex_ingest_storage_strong_consistency_requests_total{component="partition-reader"}[%(range)s])) > 0

@cursor cursor Bot Aug 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alert gate ignores strong consistency

Medium Severity

The and clause no longer requires with_offset="true" samples, so it matches any strong-consistency traffic. When only with_offset="false" requests exist, the ratio is 100% and the total rate is positive, so StrongConsistencyOffsetMissing still fires under default eventual consistency.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 236f18b. Configure here.

||| % {
alert_aggregation_labels: $._config.alert_aggregation_labels,
range: $.rateInterval('1m'),
Expand Down