chore(scripts): use env for bash/sh shebangs in dev and CI scripts - #16425
Draft
karlskewes wants to merge 2 commits into
Draft
chore(scripts): use env for bash/sh shebangs in dev and CI scripts#16425karlskewes wants to merge 2 commits into
karlskewes wants to merge 2 commits into
Conversation
Hardcoded #!/bin/bash and #!/bin/sh shebangs fail on systems where those interpreters aren't at that exact path, e.g. NixOS, which does not put bash at /bin/bash. Use /usr/bin/env to resolve the interpreter from PATH instead. Scripts that only run inside built container images or as packaging maintainer scripts are left unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
#!/usr/bin/env bashor#!/usr/bin/env shinstead of hardcoded interpreter pathsbad interpreterfailures on systems without/bin/bash, e.g. NixOS