fix(api-core): move http encoding into transcode method - #18218
Merged
Conversation
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces path traversal validation to prevent '.' and '..' segments in path template wildcards, and adds percent-encoding support to URI variable transcoding within google/api_core/path_template.py. Additionally, comprehensive unit tests have been added to verify these validation rules and encoding behaviors. There are no review comments, so we have no feedback to provide.
daniel-sanche
marked this pull request as ready for review
August 25, 2026 19:02
ohmayr
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the yanked api-core release, http encoding was added to
path_template.expand. This method is used for grpc requests in firestore, which lead to a bug.This PR moves the encoding logic into
transcode, which is the intended place for http encoding logicFixes #18213
Fixes #18207