Skip to content

test(secretmanager): add integration and unit parametrization to include OTel integration testing #18217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chalmerlowe wants to merge 4 commits into
base: feat/otel-tracing-transport-logic
Choose a base branch
from
Draft

test(secretmanager): add integration and unit parametrization to include OTel integration testing #18217

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d825d9d
chore(secretmanager): parameterize unit session to include OTel testing
chalmerlowe Aug 25, 2026
151dc64
chore(secretmanager): use google-api-core extras for OTel testing in …
chalmerlowe Aug 25, 2026
dcc60bf
chore(secretmanager): run integration tests only on default Python ve…
chalmerlowe Aug 25, 2026
403c6bf
chore(secretmanager): restrict unit session to tests/unit
chalmerlowe Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions packages/google-cloud-secret-manager/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,15 +264,26 @@ def install_unittest_dependencies(session, *constraints):

@nox.session(python=ALL_PYTHON)
@nox.parametrize(
"protobuf_implementation",
["python", "upb"],
["protobuf_implementation", "install_otel"],
[
("python", True),
("python", False),
("upb", True),
("upb", False),
],
)
def unit(session, protobuf_implementation):
def unit(session, protobuf_implementation, install_otel):
# Install all test dependencies, then install this package in-place.

constraints_path = str(
CURRENT_DIRECTORY / "testing" / f"constraints-{session.python}.txt"
)
if install_otel:
session.install("opentelemetry-sdk", "opentelemetry-instrumentation-grpc")
pytest_path = "tests"
else:
pytest_path = os.path.join("tests", "unit")
Comment thread
chalmerlowe marked this conversation as resolved.
Outdated

install_unittest_dependencies(session, "-c", constraints_path)

# Run py.test against the unit tests.
Expand All @@ -286,7 +297,7 @@ def unit(session, protobuf_implementation):
"--cov-config=.coveragerc",
"--cov-report=",
"--cov-fail-under=0",
os.path.join("tests", "unit"),
pytest_path,
*session.posargs,
env={
"PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION": protobuf_implementation,
Expand Down Expand Up @@ -367,12 +378,7 @@ def system(session):
)


@nox.session(python=DEFAULT_PYTHON_VERSION)
def integration(session):
"""Run integration tests with OpenTelemetry."""
session.install("-e", ".")
session.install("pytest", "opentelemetry-sdk", "opentelemetry-instrumentation-grpc")
session.run("py.test", "tests/integration", *session.posargs)



@nox.session(python=DEFAULT_PYTHON_VERSION)
Expand Down
Loading