feat(bigquery-jdbc): add opt-out controls - #14199
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces in-memory aggregation of telemetry events (connection attempts, statement executions, error metrics, and feature usages) in TelemetryBatcher before flushing, along with support for dynamically enabling or disabling telemetry via connection properties or environment variables. The feedback highlights a critical issue with configuring the global TelemetryManager singleton using connection-specific properties, which ignores settings for subsequent connections. Additionally, the reviewer recommends replacing a large switch statement in toStatementType with dynamic enum mapping, copying explicit_bounds when merging duration histograms to prevent invalid payloads, and explicitly handling positive values for the GOOGLE_CLOUD_TELEMETRY_ENABLED environment variable.
| } | ||
|
|
||
| private void populatePayloadBuilder(TelemetryPayload.Builder builder, List<Message> events) { | ||
| Map<String, ConnectionAttempt.Builder> connections = new HashMap<>(); |
There was a problem hiding this comment.
I am changing this Map structure in the next PR. Adding that 1 also here makes this a very big PR. So I am stacking the related changes onto the next PR.
1 participant
No description provided.