refactor(gax): add startUnaryCall to HttpJsonClientCalls - #14136
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors HttpJsonClientCalls.java by extracting the logic for starting a unary call from futureUnaryCall into a new helper method, startUnaryCall. This new method accepts a custom HttpJsonClientCall.Listener parameter, allowing for more flexible call handling, while futureUnaryCall is updated to delegate to this helper. There are no review comments, and I have no feedback to provide.
whowes
changed the title
whowes
changed the title
whowes
force-pushed
the
whowes/start-unary-call
branch
from
August 21, 2026 00:37
abf6f55 to
37eaf01
Compare
whowes
force-pushed
the
whowes/start-unary-call
branch
from
August 24, 2026 19:40
37eaf01 to
51d3a10
Compare
whowes
force-pushed
the
whowes/start-unary-call
branch
2 times, most recently
from
August 25, 2026 21:44
40a0bf9 to
84d4293
Compare
whowes
force-pushed
the
whowes/start-unary-call
branch
from
August 25, 2026 22:00
84d4293 to
b9389c0
Compare
whowes
force-pushed
the
whowes/start-unary-call
branch
from
August 26, 2026 17:56
b9389c0 to
897fba0
Compare
whowes
force-pushed
the
whowes/start-unary-call
branch
2 times, most recently
from
August 26, 2026 18:28
de0deb7 to
52161e1
Compare
whowes
force-pushed
the
whowes/start-unary-call
branch
from
August 26, 2026 18:38
52161e1 to
5f7b499
Compare
whowes
force-pushed
the
whowes/start-unary-call
branch
3 times, most recently
from
August 27, 2026 00:42
8d5ca43 to
52de5c5
Compare
whowes
force-pushed
the
whowes/start-unary-call
branch
from
August 27, 2026 00:42
52de5c5 to
3cdf3ad
Compare
whowes
force-pushed
the
whowes/start-unary-call
branch
from
August 27, 2026 15:27
3cdf3ad to
30feb38
Compare
whowes
force-pushed
the
whowes/start-unary-call
branch
from
August 27, 2026 20:15
30feb38 to
0776d87
Compare
whowes
marked this pull request as ready for review
August 27, 2026 20:19
whowes
force-pushed
the
whowes/start-unary-call
branch
from
August 27, 2026 20:58
0776d87 to
dfd32d0
Compare
whowes
force-pushed
the
whowes/start-unary-call
branch
from
August 27, 2026 23:52
dfd32d0 to
40207ef
Compare
whowes
force-pushed
the
whowes/start-unary-call
branch
from
August 28, 2026 01:34
40207ef to
604ac83
Compare
whowes
force-pushed
the
whowes/start-unary-call
branch
from
August 28, 2026 16:49
604ac83 to
765d9bc
Compare
whowes
force-pushed
the
whowes/start-unary-call
branch
from
August 28, 2026 17:02
765d9bc to
0b35123
Compare
blakeli0
approved these changes
Aug 28, 2026
whowes
force-pushed
the
whowes/start-unary-call
branch
from
August 28, 2026 19:11
0b35123 to
d6e1146
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HttpJsonClientCalls currently allows callers access to the HTTP response body. The newly-added startUnaryCall allows callers to provide a Listener that allows action based on status codes and headers, both of which are needed for resumable uploads.