Skip to content

chore(storage): reduce deprecation warnings from tests #16405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scotthart merged 2 commits into from
Sep 1, 2026
+8 −2
Merged

chore(storage): reduce deprecation warnings from tests #16405

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e5cf2f
chore(storage): reduce deprecation warnings from tests
scotthart Aug 31, 2026
e6cf5c1
formatting
scotthart Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions google/cloud/storage/internal/async/writer_connection_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// TODO(#16404): Remove deprecation disable include.
#include "google/cloud/internal/disable_deprecation_warnings.inc"

#include "google/cloud/storage/internal/async/writer_connection_impl.h"
#include "google/cloud/mocks/mock_async_streaming_read_write_rpc.h"
#include "google/cloud/storage/async/options.h"
Expand Down
3 changes: 3 additions & 0 deletions google/cloud/storage/internal/checksum_helpers_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// TODO(#16404): Remove deprecation disable include.
#include "google/cloud/internal/disable_deprecation_warnings.inc"

#include "google/cloud/storage/internal/checksum_helpers.h"
#include "google/cloud/storage/internal/object_requests.h"
#include <gtest/gtest.h>
Expand Down
5 changes: 3 additions & 2 deletions google/cloud/storage/internal/object_requests_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// TODO(#16404): Remove deprecation disable include.
#include "google/cloud/internal/disable_deprecation_warnings.inc"
Comment on lines +15 to +16

@gemini-code-assist gemini-code-assist Bot Aug 31, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Disabling deprecation warnings for the entire file can mask accidental uses of deprecated APIs in other tests within this file. Since the suppression was previously localized specifically to the InsertObjectBackwardsCompat test, it is highly recommended to keep it localized there using disable_deprecation_warnings.inc and diagnostics_pop.inc to maintain warning coverage for the rest of the file.


#include "google/cloud/storage/internal/object_requests.h"
#include "google/cloud/storage/internal/object_access_control_parser.h"
#include "google/cloud/storage/internal/object_acl_requests.h"
Expand Down Expand Up @@ -189,7 +192,6 @@ TEST(ObjectRequestsTest, InsertObjectMediaUpdateContents) {
EXPECT_EQ("new contents", request.payload());
}

#include "google/cloud/internal/disable_deprecation_warnings.inc"
TEST(ObjectRequestsTest, InsertObjectBackwardsCompat) {
auto const payload =
std::string("The quick brown fox jumps over the lazy dog");
Expand All @@ -201,7 +203,6 @@ TEST(ObjectRequestsTest, InsertObjectBackwardsCompat) {
EXPECT_EQ(zebras, request.payload());
EXPECT_EQ(zebras, request.contents());
}
#include "google/cloud/internal/diagnostics_pop.inc"

TEST(ObjectRequestsTest, Copy) {
CopyObjectRequest request("source-bucket", "source-object", "my-bucket",
Expand Down
3 changes: 3 additions & 0 deletions google/cloud/storage/internal/signed_url_requests_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// TODO(#16404): Remove deprecation disable include.
#include "google/cloud/internal/disable_deprecation_warnings.inc"

#include "google/cloud/storage/internal/signed_url_requests.h"
#include "google/cloud/internal/format_time_point.h"
#include "google/cloud/internal/parse_rfc3339.h"
Expand Down
Loading