Skip to content

fix: enable strict positional enforcement for the test suite under pytest #2802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skippdot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: enable strict positional enforcement for the test suite under pytest #2802

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69970ba
fix: enable strict positional enforcement for the test suite under py…
skippdot Sep 1, 2026
fee2e33
fix: use addCleanup to restore enforcement setting
skippdot Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@

from googleapiclient import _helpers as util


def setup_package():
"""Run on testing package."""
util.positional_parameters_enforcement = "EXCEPTION"
# The test suite is written against strict positional parameter enforcement:
# violations must raise TypeError rather than only log a warning. This used to
# be configured in a nose-era setup_package() hook, which pytest never calls,
# so set it at import time instead.
util.positional_parameters_enforcement = util.POSITIONAL_EXCEPTION
8 changes: 8 additions & 0 deletions tests/test__helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@


class PositionalTests(unittest.TestCase):
def setUp(self):
self._saved_enforcement = _helpers.positional_parameters_enforcement

def tearDown(self):
# These tests mutate the module-level enforcement setting; restore it
# so the rest of the suite keeps running in strict mode.
_helpers.positional_parameters_enforcement = self._saved_enforcement
Comment thread
skippdot marked this conversation as resolved.
Outdated

def test_usage(self):
_helpers.positional_parameters_enforcement = _helpers.POSITIONAL_EXCEPTION

Expand Down
Loading