profile: preserve inline frame columns in location merge keys - #1016
Open
cuishuang wants to merge 1 commit into
Open
profile: preserve inline frame columns in location merge keys#1016cuishuang wants to merge 1 commit into
cuishuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The location merge key allocates three fields per inline frame (function, line, and column), but indexes each frame using a stride of two. As a result, the function ID of a later inline frame overwrites the column of the preceding frame.
For example, locations that differ only in the column of a non-terminal inline frame can be incorrectly merged, causing samples from distinct source locations to be aggregated together.
Use a stride of three when encoding function IDs, line numbers, and column numbers in the location key.