Repository navigation
perfetto: support big-endian in trace_processor_shell paths - #8256
Merged
Merged
Conversation
Member
|
Thanks for the patch! Unfortunately a bunch of these are not actually trace processor related but are producer side things (shared memory, buffered ipc serializer etc) Could you please scope this patch to just TP changes? |
Contributor
Author
Should be good now, PTAL. |
LalitMaganti
approved these changes
Oct 26, 2026
Member
|
The auto-format check seems to be failing PTAL. |
sashwinbalaji
approved these changes
Oct 26, 2026
sashwinbalaji
approved these changes
Oct 26, 2026
LalitMaganti
enabled auto-merge (squash)
October 26, 2026 16:57
LalitMaganti
approved these changes
Oct 26, 2026
auto-merge was automatically disabled
October 26, 2026 17:33
Head branch was pushed to by a user without write access
Contributor
Author
Apologies, it was failing again. It should be good now |
LalitMaganti
approved these changes
Oct 26, 2026
sashwinbalaji
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In nodejs/node#65794, we're trying to test our Perfetto integration on several platforms, one of which is s390x (support was added by #7449) but the cross-compilation fails when it reaches little-endian assertions.
I've tasked an LLM-agent to make a patch, and here's what it came up with. I've validated that I was able to cross-compile for s390x.