Skip to content

tests: allow unwinding test to compile against libunwindstack header changes #7032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rsavitski merged 1 commit into from
Aug 11, 2026
+10 −5
Merged

tests: allow unwinding test to compile against libunwindstack header changes #7032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/profiling/perf/frame_pointer_unwinder_unittest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,13 @@ class RegsFake : public unwindstack::Regs {
}
~RegsFake() override = default;

unwindstack::ArchEnum Arch() override { return fake_arch_; }
unwindstack::ArchEnum Arch() { return fake_arch_; }
unwindstack::ArchEnum Arch() const { return fake_arch_; }
void* RawData() override { return fake_data_.get(); }
uint64_t pc() override { return fake_pc_; }
uint64_t sp() override { return fake_sp_; }
uint64_t pc() { return fake_pc_; }
uint64_t pc() const { return fake_pc_; }
uint64_t sp() { return fake_sp_; }
uint64_t sp() const { return fake_sp_; }
void set_pc(uint64_t pc) override { fake_pc_ = pc; }
void set_sp(uint64_t sp) override { fake_sp_ = sp; }

Expand All @@ -67,7 +70,8 @@ class RegsFake : public unwindstack::Regs {

bool SetPcFromReturnAddress(unwindstack::Memory*) override { return false; }

void IterateRegisters(std::function<void(const char*, uint64_t)>) override {}
void IterateRegisters(std::function<void(const char*, uint64_t)>) {}
void IterateRegisters(std::function<void(const char*, uint64_t)>) const {}

bool StepIfSignalHandler(uint64_t,
unwindstack::Elf*,
Expand All @@ -77,7 +81,8 @@ class RegsFake : public unwindstack::Regs {

void FakeSetArch(unwindstack::ArchEnum arch) { fake_arch_ = arch; }

Regs* Clone() override { return nullptr; }
Regs* Clone() { return nullptr; }
Regs* Clone() const { return nullptr; }

private:
unwindstack::ArchEnum fake_arch_ = unwindstack::ARCH_UNKNOWN;
Expand Down