Ensure object-src: 'none' CSP directive is applied as intended - #6988
Open
Svetlitski wants to merge 1 commit into
Open
Ensure object-src: 'none' CSP directive is applied as intended#6988Svetlitski wants to merge 1 commit into
object-src: 'none' CSP directive is applied as intended#6988Svetlitski wants to merge 1 commit into
Conversation
[According to MDN](https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Content-Security-Policy/object-src#none) the single-quotes surrounding `'none'` are mandatory. Unlike the other CSP directives that take care to preserve these single-quotes when required (e.g. `'self'` in `connect-src`), the `object-src` was passing a plain `none` without quotes, which is treated as the bare hostname `none`.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
LalitMaganti
approved these changes
Aug 7, 2026
sashwinbalaji
approved these changes
Aug 7, 2026
rsavitski
approved these changes
Aug 7, 2026
Member
|
@Svetlitski I think we just need you to sign the CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to MDN the single-quotes surrounding
'none'are mandatory in theobject-srcCSP directive. Unlike the other CSP directives that take care to preserve these single-quotes when required (e.g.'self'inconnect-src), theobject-srcwas passing a plainnonewithout quotes, which is treated as the bare hostnamenone.