ui: add "Open in default workspace" button to slice details - #6940
ui: add "Open in default workspace" button to slice details#6940zezeozue wants to merge 2 commits into
Conversation
Show a button in the slice details panel that switches to the default workspace and scrolls to the selected slice there. It appears only when the selection is in a non-default workspace and the track also exists in the default workspace. Change-Id: I30605bf17ee50d2dc0d3a42ccbb13890bbabc1cf
🎨 Perfetto UI Builds
|
There was a problem hiding this comment.
Can you find a way to do this more generically? E.g. if you're not on the main workspace, and your selected track exists on a the main workspace, add a button to all details panels.
I think it might be awkward to inject a button into all details panels, but if you can think of a nice way to do it that could be a much neater solution.
The UI really suffers from inconsistent features like this that are implemented for some tracks/plugins but not others.
Render the button once in CurrentSelectionTab, the single host through which every selection's details panel is rendered, instead of adding it to individual panels. It is merged into the details panel's DetailsShell for track_event and track selections whose track is in a non-default workspace but also exists in the default one. Change-Id: I899ddfd8b9151dea07d20c461263bd69f3336b55
Lmk what you think of the current approach. Seems to work fine for slices, thread_state, counters |
2 participants
Show a button in the slice details panel that switches to the default workspace and scrolls to the selected slice there. It appears only when the selection is in a non-default workspace and the track also exists in the default workspace.