Trace size optimization: Remove unreferenced intern table entries in redacted traces - #6912
Open
edgararriagag wants to merge 2 commits into
Open
Trace size optimization: Remove unreferenced intern table entries in redacted traces#6912edgararriagag wants to merge 2 commits into
edgararriagag wants to merge 2 commits into
Conversation
🎨 Perfetto UI Builds
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This optimization reduces trace size by eliminating every unreferenced thread name from the compact sched intern table which is results from redaction, as redaction currently leaves dangling references that consume significant trace size as they are lists of strings.
The average gains in trace size with this optimization are ~9.6% of trace size.
Note: Internal tracking bug b/539563625