Skip to content

ci: avoid duplicating release notes on existing releases #3919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
locker95 wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −1
Open

ci: avoid duplicating release notes on existing releases #3919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion .github/workflows/release-binaries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,25 @@ jobs:
- name: Display structure of downloaded files
run: ls -R artifacts

# softprops/action-gh-release appends freshly generated notes to any
# existing release body. Maintainers often create the GitHub Release
# (with auto-generated notes) before this workflow uploads binaries,
# which produced duplicated "What's Changed" sections. Only generate
# notes when the release does not already have a body.
- name: Decide whether to generate release notes
id: release_notes
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
if gh release view "${VERSION}" >/dev/null 2>&1; then
body="$(gh release view "${VERSION}" --json body -q .body 2>/dev/null || true)"
if [ -n "${body}" ]; then
echo "generate=false" >> "${GITHUB_OUTPUT}"
exit 0
fi
fi
echo "generate=true" >> "${GITHUB_OUTPUT}"

- name: Create Release
id: create_release
uses: softprops/action-gh-release@v2
Expand All @@ -107,6 +126,6 @@ jobs:
name: cAdvisor ${{ env.VERSION }}
draft: false
prerelease: ${{ contains(env.VERSION, 'alpha') || contains(env.VERSION, 'beta') || contains(env.VERSION, 'rc') }}
generate_release_notes: true
generate_release_notes: ${{ steps.release_notes.outputs.generate }}
files: |
artifacts/**/*
Loading