Skip to content

Use UTF-8 encoding in all files - #215

Merged
NathanLovato merged 3 commits into
godotengine:masterfrom
charjr:utf8-encoding
Jul 15, 2026
Merged

NathanLovato merged 3 commits into
godotengine:masterfrom
charjr:utf8-encoding

Conversation

@charjr

@charjr charjr commented Jul 14, 2026 •

Copy link
Copy Markdown
Contributor

Important

Ignore whitespace changes to review this PR
image

What Changed?

6 files used MS-DOS encoding, which (depending on how you use git) leads to seeing strange ^Ms at the end of every single line.

This PR adjusts these files to use UTF-8 encoding for consistency with the rest of the package.

Before After
image image

As such, the PR looks huge because it changes every single end-of-line character. But if you ignore whitespace (see the screenshot at the top) then the only real change is to add a .editorconfig file to reduce the risk of this happening again.

Closes #139

@charjr
charjr force-pushed the utf8-encoding branch 2 times, most recently from e9d3594 to f14ae6f Compare July 15, 2026 18:18
charjr added 2 commits July 15, 2026 19:27
The purpose of this set of commits is to use utf-8 encoding.
So I do not want to overstep the scope.

Also indent size does not play nicely with elisp indentation,
which has a lot of contextually different indentation levels:
i.e. `let' and `if' statements.
@NathanLovato

Copy link
Copy Markdown
Collaborator

Please let me know when this is ready to merge, the change is looking good to me.

@charjr

charjr commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Please let me know when this is ready to merge, the change is looking good to me.

@NathanLovato I believe it is ready to go now. 🚀 Thank you for reviewing! 💯

@NathanLovato
NathanLovato merged commit 8b5b568 into godotengine:master Jul 15, 2026
9 checks passed
@charjr
charjr deleted the utf8-encoding branch July 15, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consistent text file formatting in this code base

2 participants