Skip to content

fix(extensions): restore pre-bundle AST security scan [DEVEX-710] #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpage-godaddy merged 6 commits into from
Aug 24, 2026
Merged

fix(extensions): restore pre-bundle AST security scan [DEVEX-710] #208

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c0973f5
fix(extensions): restore pre-bundle AST security scan [DEVEX-710]
qcai-godaddy Aug 12, 2026
8029057
address comments
qcai-godaddy Aug 12, 2026
a864d4e
fail closed on parse errors
qcai-godaddy Aug 12, 2026
b31243e
harden snippet slicing and stabilize finding sort
qcai-godaddy Aug 12, 2026
7bbbdfe
use ScanError and reject symlinks in discovery
qcai-godaddy Aug 12, 2026
d22cb50
Delete PR-DEVEX-710.md
qcai-godaddy Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,16 @@ GoDaddy CLI is a Rust binary (edition 2024) built using:

### Extension security scanner

- Pre-bundle AST scan in `extension/security/` (oxc): SEC001–SEC010, SEC012, plus
SEC011 package scripts (`scan_extension`).
- Post-bundle regex scanner in `extension/security/mod.rs` (rule data in
`extension/security/rules.rs`).
- Rules SEC101–SEC110 ported from the TS scanner; SEC111–SEC115 added in the
Rust port with no TS baseline (SEC111/SEC112/SEC115 block, SEC113/SEC114
warn). Uses `fancy-regex` for lookahead support.
- `scan_bundle(content, path) -> Vec<Finding>`, `is_blocked(findings) -> bool`.
- `scan_extension(dir) -> Result<ScanReport>`, `scan_bundle(content, path) -> Vec<Finding>`,
`is_blocked(findings) -> bool`.
- Deploy runs pre-bundle scan before esbuild, then post-bundle scan on the artifact.

### esbuild dependency

Expand Down
Loading
Loading