Don't pass unused parameters in fetch method - #819
Open
roarc0 wants to merge 1 commit into
Open
Conversation
StantonMatt
reviewed
Jun 3, 2026
StantonMatt
left a comment
StantonMatt
left a comment
There was a problem hiding this comment.
I checked this locally. The cleanup looks behavior-neutral: the removed fetch arguments are already available through the constructed *http.Request, and Request is still populated from req.URL, req.Header, req.Host, the method, body, context, and depth.
Validation:
go test ./... -count=1
git diff --check origin/master...HEADBoth passed. GitHub reports no hosted checks for this PR branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.