Skip to content

Queue Depth functionality + Panic with Async #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KristinnVikar wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Queue Depth functionality + Panic with Async #774

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
536bd99
add proper Depth support for queue crawling
Jul 20, 2023
0395e64
panic on unsupported Async within Queue
Jul 20, 2023
69d11ae
add tests
Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions queue/queue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ func (q *Queue) AddURL(URL string) error {
r := &colly.Request{
URL: u2,
Method: "GET",
Depth: 1,
}
d, err := r.Marshal()
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ func (r *Request) Retry() error {

// Do submits the request
func (r *Request) Do() error {
return r.collector.scrape(r.URL.String(), r.Method, r.Depth, r.Body, r.Ctx, *r.Headers, !r.collector.AllowURLRevisit)
return r.collector.scrape(r.URL.String(), r.Method, r.Depth+1, r.Body, r.Ctx, *r.Headers, !r.collector.AllowURLRevisit)

@WGH- WGH- Oct 17, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this change. Could you please clarify? The test you added doesn't catch it if I revert this change.

@KristinnVikar KristinnVikar Nov 8, 2023

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd, the TestCollectorDepth test should catch that, it's so that the depth increases on each request, so that you can use MaxDepth in Queue-based crawlers. I'll take a look at it.

}

// Marshal serializes the Request
Expand Down