fix: deduplicate Allow header in 405 Method Not Allowed responses#1124
Open
happysnaker wants to merge 1 commit into
Open
fix: deduplicate Allow header in 405 Method Not Allowed responses#1124happysnaker wants to merge 1 commit into
happysnaker wants to merge 1 commit into
Conversation
When multiple routes with the same HTTP method but different patterns
are registered (e.g., /article/{a} and /article/{b}-{c}), the Allow header
in 405 responses contains duplicate method entries.
This commit deduplicates the Allow header by tracking seen methods.
Fixes go-chi#996
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #996
When multiple routes with the same HTTP method but different patterns are registered (e.g.,
/article/{a},/article/{b}-{c},/article/{b}-{c}-{d}), theAllowheader in 405 responses contains duplicate method entries like:Changes
methodNotAllowedHandlerusing aseenmap to track methods already added to the Allow headerBefore
After