fix(middleware): properly parse Accept-Encoding with quality values#1123
Open
happysnaker wants to merge 1 commit into
Open
fix(middleware): properly parse Accept-Encoding with quality values#1123happysnaker wants to merge 1 commit into
happysnaker wants to merge 1 commit into
Conversation
Fix two issues in matchAcceptEncoding: 1. Substring matching: 'strings.Contains(v, encoding)' caused false positives (e.g. 'br' matched encoding 'b', 'bgzip' matched 'gzip'). Now uses exact EqualFold comparison after stripping params. 2. q=0 ignored: 'gzip;q=0' was treated as acceptable per RFC 9110 Section 12.5.3, q=0 means the encoding is not acceptable. Now checks for exact q=0 / q=0.0 / q=0.00 / q=0.000 and skips. Also uses EqualFold for case-insensitive matching per RFC 9110. Fixes go-chi#1069 Signed-off-by: happysnaker <73147033+happysnaker@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1069
The compress middleware currently fails to properly parse headers that include quality (q) values, such as:
The existing parsing logic does not strip quality values before matching, causing the middleware to not recognize valid encodings.
Changes
*) in the presence of quality valuesTesting