fix(middleware): honor all-types compress wildcard#1121
Open
happysnaker wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Maintainer context:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewCompressor(..., "/*")behave as an actual all-types wildcardapplication/*andtext/*responsesProblem
NewCompressor(5, "/*")is currently accepted as a valid wildcard pattern, but it silently does not work.During setup, the pattern is normalized into an empty wildcard key via
strings.CutSuffix("/*", "/*"), which is fine as an internal sentinel. The problem is inisCompressible(): wildcard matching only checks the top-level media type prefix (for exampletextorapplication) and never treats the empty key as a match-all sentinel.That means the following configuration looks valid but compresses nothing:
Changes
"/*"now compresses bothapplication/jsonandtext/html; charset=utf-8The patch is intentionally narrow: it does not change the wildcard syntax rules, only makes the already-accepted
"/*"form behave consistently.Closes #868