fix(middleware): fix Accept-Encoding matching in compress middleware#1114
Open
boatnoah wants to merge 2 commits into
Open
fix(middleware): fix Accept-Encoding matching in compress middleware#1114boatnoah wants to merge 2 commits into
boatnoah wants to merge 2 commits into
Conversation
993338a to
0cb1898
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1069
Summary
matchAcceptEncodingused substring matching, so values likebgzipcould matchgzip, and encodings explicitly rejected withq=0were still selected.Fix
Parse each
Accept-Encodingitem as an encoding token plus parameters, compare the token andqparameter name case-insensitively, and reject matches with a parsed quality value of0or lower.This intentionally keeps the existing server-side encoder precedence and does not add wildcard or q-priority negotiation.
Tests
Added helper-level regression coverage for exact matching, substring false positives, whitespace, mixed-case tokens and parameters,
q=0/q=0.0, and multiple accepted encodings.Added middleware-level cases for
gzip;q=0returning no encoding and falling back todeflatewhen available.