feat(middleware): compress all text/* types by default#1057
Open
acme wants to merge 1 commit into
Open
Conversation
- Replace explicit `text/html`, `text/css`, `text/plain`, `text/javascript` entries in `defaultCompressibleContentTypes` with a single `text/*` wildcard - Fix `NewCompressor` to parse wildcard patterns in the defaults path, not only when types are explicitly passed - Add test asserting `text/markdown` is gzip-compressed with default settings
5 tasks
Contributor
|
This needs a rebase but other than that seems like a really nice improvement that brings symmetry between user-supplied and default compression content types. I wonder if we might even be able to merge the loops now that they both support wildcards? What do you think of this change @VojtechVitek ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
text/html,text/css,text/plain,text/javascriptentries indefaultCompressibleContentTypeswith a singletext/*wildcardNewCompressorto parse wildcard patterns in the defaults path, not only when types are explicitly passedtext/markdownis gzip-compressed with default settingsI realise there have been a number of compression-related pull requests in the past, but hopefully this is small enough and has tests so is easy to merge in.