Repository navigation
Conversation
jdemel
force-pushed
the
fix-fmtlib-fetch-content
branch
from
September 13, 2026 11:32
7ecb050 to
2281000
Compare
Restrict the CMake FetchContent option to static builds explicitly. This should not interfere with other systems where fmtlib should've been installed. Signed-off-by: Johannes Sterz Demel <jdemel@gnuradio.org>
Signed-off-by: Johannes Sterz Demel <jdemel@gnuradio.org>
jdemel
force-pushed
the
fix-fmtlib-fetch-content
branch
from
September 13, 2026 15:46
2281000 to
8e54f1c
Compare
Signed-off-by: Johannes Sterz Demel <jdemel@gnuradio.org>
Signed-off-by: Johannes Sterz Demel <jdemel@gnuradio.org>
Signed-off-by: Johannes Sterz Demel <jdemel@gnuradio.org>
Signed-off-by: Johannes Sterz Demel <jdemel@gnuradio.org>
jdemel
force-pushed
the
fix-fmtlib-fetch-content
branch
from
September 13, 2026 16:15
8e54f1c to
30bddce
Compare
Contributor
Author
|
It turns out, quite a few configurations depend on the FetchContent approach to provide fmtlib. Also, switching to a system fmtlib install turn out to be challenging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restrict the CMake FetchContent option to static builds explicitly. This should not interfere with other systems where fmtlib should've been installed.
A few more lines where touched because I auto-formatted the CMake file as well.
Fixes #876