Skip to content

fix: Best practices review - #179

Merged
D4ryl00 merged 7 commits into
gnoverse:mainfrom
jefft0:fix/best-practices-review
Oct 29, 2026
Merged

D4ryl00 merged 7 commits into
gnoverse:mainfrom
jefft0:fix/best-practices-review

Conversation

@jefft0

@jefft0 jefft0 commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

These are fixes following a best practices review for the dsocial realm.

  • Make functions private if they return a pointer to a state object. (Avoid cross-realm modification)
  • public.gno: Add checks for cur.IsCurrent() per gno-security-guide.md
  • MarshalJSON: Add comment of possible invalid JSON from the post body
  • Render: Use markdown/sanitize for text and paths
  • RenderPost: Add a TODO comment for the need to paginate. (Already done in boards2)
  • Post.GetURL: Handle a repost URL correctly
  • .tool-versions: Use golang 1.25.9 (same as the gno go.mod)

…bject. Avoid cross-realm modification

Signed-off-by: Jeff Thompson <jeff@thefirst.org>
…e.md

Signed-off-by: Jeff Thompson <jeff@thefirst.org>
…t body

Signed-off-by: Jeff Thompson <jeff@thefirst.org>
Signed-off-by: Jeff Thompson <jeff@thefirst.org>
Signed-off-by: Jeff Thompson <jeff@thefirst.org>
Signed-off-by: Jeff Thompson <jeff@thefirst.org>
Signed-off-by: Jeff Thompson <jeff@thefirst.org>
@jefft0
jefft0 requested a review from D4ryl00 October 28, 2026 15:58
@jefft0
jefft0 marked this pull request as ready for review October 28, 2026 15:59

@D4ryl00 D4ryl00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@D4ryl00
D4ryl00 merged commit c950a0f into gnoverse:main Oct 29, 2026
3 checks passed
@jefft0
jefft0 deleted the fix/best-practices-review branch October 29, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants