Conversation
- Observe appearance changes to apply styling dynamically when switching themes - macOS 26: use container-based design matching sponsor cards - Pre-26 systems: frosted glass with dark scrim for dark themes only - New iTermAboutCreditsWellView class to manage credits background - Shared helpers (iTermAboutContainerCornerRadius, iTermAboutContainerFillColor) for consistent styling
- Reorganize into single centered column with app icon, title, version, and action buttons - Add action buttons (Home, Report Bug, Credits) with responder chain routing - Display sponsor cards in a row and backers in a rounded well (renamed from credits) - Increase window height from 413 to 600px to accommodate new layout - Add iTermAboutBakedBackgroundColorOfImage() helper to extract colors from sponsor images - Refactor typography with explicit font sizes and spacing constants aligned to 8pt scale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Stacks on #632 (its commit is the first of the two here). Two things I'd like your view on before this leaves draft, both under Open questions below: the window height, and transparent versions of two sponsor logos.
📄 Description
Redesigns the About window as one centred column, read top to bottom like a credits roll: who made it, who sponsors it, who backs it, and how to join them.
iTerm2at 22pt semibold; the byline insecondaryLabelColor; the build number and What's New on one line intertiaryLabelColor. The three underlined text links become small push buttons, which macOS 26 renders as capsules with no code of their own. The separator line is gone; fills do the grouping now.SPONSORSeyebrow over the row of cards. Cards are 56pt tall with 12pt radius on 26 (8pt before). A card whose logo has a flat colour baked into the image (currently CodeRabbit and BairesDev, which are white) becomes a tile of that colour, so the image's edge disappears into the card's rounded corners instead of showing as a rectangle inside a grey box; transparent logos keep the neutral fill. That is decided by sampling the image's four corners at runtime, so a new logo needs no code change, and a gradient or photo falls back to neutral rather than a guess.BACKERS 159eyebrow (the count from the feed) over a rounded well sharing the cards' fill and radius. Names are centred at 13pt with 1.6 line height, separated by middle dots rather than commas, and never wrap inside a name. The feed marks higher-tier backers by wrapping the name in ⭐️; those are listed first in medium weight with a small goldstar.fillbefore each, everyone else follows insecondaryLabelColor. Tier is carried by weight, colour and position as well as the star, so it survives colourblindness.secondaryLabelColor, taking over the call to action from the old bold heading.windowBackground; before 26, dark themes get frosted glass with a scrim behind the backers.The window still grows to fit the backer list, as it always has. New: it stops at the screen's visible height, and past that the well scrolls, so a long list can no longer push the window off screen.
Built and checked in the running app on macOS 26.6 under the Dark theme.
🛠️ How it's built
iTermAboutWindowContentView -layoutContent, the same way the sponsor row was already laid out. No Auto Layout.static constat file scope, on an 8pt scale except where type sets it.updateLayer(theiTermSponsorBoxViewidiom); the well isiTermAboutBackersWellView.SFSymbolGetString(SFSymbolStarFill).NSLocalizedStringWithDefaultValuewith keysAboutWindow.SponsorsHeading,AboutWindow.BackersHeading,AboutWindow.HigherTierBackerMarkerandAbout.SupportFooter; the oldAbout.BackersHeadingheading is no longer used. I have not runmake extract-strings, perdocs/localization.md, so the catalog picks them up at the next extraction.❓ Open questions
✅ How to Validate
BACKERSeyebrow, starred backers come first.🛠️ Developer Checklist