Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clipboard screenshots commonly arrive as TIFF, which remote coding agents may not accept. This improves the existing “Upload and Paste Path” action by converting TIFF/other bitmap formats to PNG, preserving supported compressed formats, and giving pasted images unique filenames. Uploads resolve the SSH Integration conductor through tmux control-mode gateways and can use its home directory before shell integration reports a working directory, including inside ordinary tmux. Successful uploads paste the actual destination after collision renaming; cancelled or obsolete completions cannot paste a path into a different session/connection.
SSH Integration uploads now send sequential 16 KiB chunks instead of 1 KiB. A 490 KiB image requires 31 append requests instead of 490. The included benchmark runs the real remote framer over an SSH PTY: measured upload time fell from approximately 4.2 seconds to 1.4–1.7 seconds, with SHA-256 verification. Larger 64 KiB chunks took approximately 3 seconds because of parser overhead. Cancellation now cleans up temporary files, handles cancellation during the final rename, and avoids leaving finished transfers in “Cancelling…”.
Validation:
ConductorUploadTests: 5 passed, covering chunk boundaries, byte preservation, progress, cancellation, and append errors.NonTextPasteImageTests: 3 passed;NSStringQuotedStringForPasteTests: 22 passed.python3 tests/benchmark_conductor_upload.py <host>verified synthetic uploads across 1, 4, 8, 16, 32, and 64 KiB chunk sizes.git diff --checkpassed.Local build/test validation used separate Xcode 27 compatibility changes and rebuilt dependencies. Those changes, generated binaries, and local fish/it2ssh setup are excluded from this PR; the isolated PR branch has not been built independently with an older toolchain. Release notes and the new localized error string are included.