fix: restore Linux glass label tooltip contrast - #3343
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux with Glass enabled, label tooltips can show green text on a strong green fill inside a light gray box. Preserve Primer’s paired label colors and use the app theme’s surface and foreground for Linux Glass tooltips. The adjustment is limited to Linux because the reported appearance is correct on other platforms.
Reproduced the issue in Chromium with the Linux renderer bridge. The green-label contrast check failed before the fix (about 3.05:1 in dark mode and 3.16:1 in light mode); the six browser cases now meet 4.5:1 and verify tooltip dismissal. These cover Glass light/dark, a stored dimmed setting, System resolving to light, and Classic light/dark.
Validation: 35 metric component tests, six browser tests, formatting/lint, TypeScript, and production build pass. The build retains its large-chunk warning. Native macOS/Windows rendering and the full pinned-container screenshot suite were not run; no screenshot baselines changed.