Skip to content

Fix shell check for no tests collected - #4

Merged
giovannic merged 1 commit into
masterfrom
bug/fix_ci
Oct 2, 2025
Merged

giovannic merged 1 commit into
masterfrom
bug/fix_ci

Conversation

@giovannic

@giovannic giovannic commented Oct 2, 2025 •

Copy link
Copy Markdown
Owner

Summary

Fix test CI

Changes

New Features

None

Breaking Changes

None

Fixes

  • CI failing for no tests collected
  • Shell test for exit code == 5 was wrong
  • Force bash shell for windows

Reviewer Checklist

All PRs

  • Correctness: Logic is sound and implementation is correct
  • Testing: Appropriate tests added/updated
  • Benchmarking: Training/sampling speed impact assessed if relevant
  • Documentation: Code comments and docs updated where needed

For AI-Generated PRs

  • Entropy: No unnecessary code duplication, verbose implementations,
    or misplaced imports
  • Test Quality: Tests genuinely validate intended behavior (check
    .claude/spec/{feature}/tasks.md for requirements)
  • Steering Docs: Fundamental changes to the repo (if any) are
    reflected in steering documents .claude/steering/

@giovannic
giovannic merged commit 394dbd2 into master Oct 2, 2025
7 checks passed
@giovannic
giovannic deleted the bug/fix_ci branch October 3, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant