Repository navigation
feat: adopt Agent Plugins 1.0 without regressing skills.sh - #29
Merged
Merged
Conversation
This was referenced Sep 3, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes Agent Plugins 1.0 a first-class additive distribution surface while preserving the existing Agent Skills / skills.sh contract.
The central invariant is unchanged:
is the single canonical runtime skill for both Agent Plugins discovery and skills.sh consumers.
What changes
scripts/validate-agent-plugin.py;skills.sh.jsonregistrations;npx skills@latest add . --listCI smoke test;mcp.json— “no custom MCP” does not mean “no MCP composition”;v1.2.2and regenerates affected manifests.MCP clarification
Agent Plugins 1.0 discovers MCP configuration from root
mcp.json. That file can configure an existing remote MCP (streamable-http) or existing executable (stdio); the MCP server does not need to be implemented inside this repository.For GitHub Build or Reuse, the current design remains no mandatory
mcp.jsonbecause the skill intentionally works with host-native GitHub APIs/connectors, the official GitHub MCP Server, authenticatedgh, or web fallback. Making one of those optional access paths mandatory would reduce portability without adding capability.Reusable MCP composition is being generalized separately in:
svg153/skills#35— catalog support for optionalmcp.json;svg153/skills#36— planning plugin pilot using existing GitHub + Jira/Atlassian MCP servers.skills.sh regression guard
This PR intentionally preserves all stable inputs used by the existing skills.sh path:
ghspain/github-build-or-reuse;github-build-or-reuse;skills/github-build-or-reuse/SKILL.md;skills.sh.jsonregistration.CI now fails if the Agent Plugins skill set diverges from
skills.sh.json, and continues to verify local discovery throughnpx skills.External skills.sh ranking/index availability is not under repository control, so it remains observed rather than becoming a brittle PR-blocking dependency.
The longer-term question of making Agent Plugins primary and retiring adapters is tracked in
svg153/skills#34; skills.sh should be retired only if equivalent discovery/install reach is demonstrated.Validation
Expected PR checks cover:
python scripts/validate.py python scripts/validate-agent-plugin.py python scripts/generate-distribution.py --check python scripts/generate_demo.py --check npx -y skills@latest add . --listTraceability
Refs #28
Parent initiative: svg153/skills#33
Follow-ups: svg153/skills#34, svg153/skills#35, svg153/skills#36
Origin: review of “Build Once, Run Everywhere: Agent Plugins Guide” and Agent Plugins 1.0.
Runtime verification on additional concrete agent hosts remains tracked in #28; this PR deliberately does not overstate unverified host compatibility.