macOS: fix non control keys are not working for AppleScript#13205
Open
bo2themax wants to merge 1 commit into
Open
macOS: fix non control keys are not working for AppleScript#13205bo2themax wants to merge 1 commit into
bo2themax wants to merge 1 commit into
Conversation
Contributor
|
I've been daily driving Ghostty with that — couldn't find any problems with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
send keyonly works for control keys likeentercurrently; this adds (fixes) the support for other keys listed as available. Found by @paaloeye in #13180The core of this fix is relying on
UCKeyTranslateto get the corresponding character and code point from a key code usingcharacters(byApplyingModifiers:). To reuse the existing code point check inghosttyCharacters, I moved that into a separate function to avoid unexpected side effects.AI Disclosure
Claude
wrote the unit tests anddid some code review.