fix: align Neptune community AOSS index#1635
Open
iroiro147 wants to merge 1 commit into
Open
Conversation
Author
|
Hi maintainers — a gentle follow-up on this bug fix for #1632. It aligns the Neptune/AOSS community index name across registration, save, fallback, and search paths, removes the invalid await in the fallback, and includes focused regression coverage. GitHub reports the branch mergeable; CLA, Ruff, and fork checks pass, and the remaining triage failure is the repository automation’s external-contributor permission check. Happy to adjust the implementation or tests if you would prefer a different approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COMMUNITY_INDEX_NAMEdefault with Neptune's registered AOSS community index (community_name)CommunityNode.save, and Neptune community fulltext searchawaitaround the sync Neptunesave_to_aossfallback callCloses #1632
Testing
make formatmake lintuv run pytest tests/driver/test_neptune_aoss_indices.py tests/driver/test_falkordb_driver.py -q-> 28 passed, 1 skipped, 1 warningUV_CACHE_DIR=/tmp/uv-cache uv run pytest tests/driver/test_neptune_aoss_indices.py -q-> 3 passed, 1 warningNotes
make test; it reached 168 passed, 2 skipped, 10 deselected, then errored on unavailable local Neo4j atlocalhost:7687intests/test_add_triplet.py. I interrupted the repeated Neo4j retries after confirming the failure was external-service setup, not this candidate change.