fix(llm): avoid mutating caller messages#1634
Open
iroiro147 wants to merge 1 commit into
Open
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA behalf on myself, e-mail: sarthak.singh@juspay.in |
Author
|
recheck |
iroiro147
force-pushed
the
fix/llm-message-immutability-1629
branch
from
July 12, 2026 16:29
8c3ab0b to
06ff176
Compare
Author
|
Hi maintainers — a gentle follow-up on this bug fix for #1629. It keeps caller-provided messages immutable across the base and provider-specific response paths, with focused regression coverage. I refreshed it onto current main; CLA, Ruff, and fork checks pass, and the remaining triage failure is the repository automation’s external-contributor permission check. Happy to adjust the approach or scope if you would prefer anything different. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate_responseprompt preparationCloses #1629
Tests
uv run pytest tests/llm_client/test_client.py tests/llm_client/test_openai_client.py tests/llm_client/test_openai_generic_client.py tests/llm_client/test_anthropic_client.py tests/llm_client/test_gemini_client.py -qmake lintmake testtests/test_add_triplet.pysetup because no local Neo4j service was available atlocalhost:7687; interrupted after repeatedneo4j.exceptions.ServiceUnavailableconnection retries