fix(docker): avoid host PATH interpolation#1630
Open
dpersek wants to merge 4 commits into
Open
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA behalf on myself, e-mail: syntaxsawdust.cgoco@passmail.net |
dpersek
marked this pull request as ready for review
July 4, 2026 16:03
Contributor
|
@dpersek Confirmed the leak: my host paths showed up inside the container via docker compose config. Your change fixes it and the image Dockerfile already sets PATH. LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docker Compose no longer injects the host process
PATHinto the MCP server containers. This prevents Windows host paths from replacing the Linux image PATH that startup commands rely on.The Dockerfiles already bake
/root/.local/bininto the image PATH, so the compose-level override was redundant and could break startup when${PATH}expanded to something likeC:\Windows\system32;C:\Windows.Type of Change
Objective
Fix the Docker Compose startup failure reported in #1623 without changing Dockerfile install behavior, service commands, or runtime configuration.
Testing
Validation run:
PATH='C:\Windows\system32;C:\Windows' docker compose -f mcp_server/docker/docker-compose.yml config --quietPATH='C:\Windows\system32;C:\Windows' docker compose -f mcp_server/docker/docker-compose-falkordb.yml config --quietPATH='C:\Windows\system32;C:\Windows' docker compose -f mcp_server/docker/docker-compose-neo4j.yml config --quietgit diff --check upstream/mainI also checked rendered config output for all three compose files with the same simulated Windows-style host PATH. After this change, the compose files no longer render a container
PATHoverride.Not run: full test suite /
make lint. This change only removes compose-file PATH interpolation; no Python code changed. GitHub'sruffcheck is passing on the draft PR.Breaking Changes
Scope
/root/.local/binpermission issue from MCP server fails to start via Docker Compose #665 or the separate Dockerfile-focused PR fix(docker): install uv system-wide so runtime works under non-root #981.Caveats
Checklist
make lintpasses)Related Issues
Fixes #1623