fix: avoid FalkorDB edge rematch scans#1494
Closed
mturac wants to merge 1 commit into
Closed
Conversation
danielchalef
added a commit
to jaredloman/graphiti
that referenced
this pull request
Jun 9, 2026
DB-free query-shape regression test asserting edge_fulltext_search and edge_bfs_search derive endpoints via startNode/endNode instead of the O(matches×graph) re-MATCH by uuid. Placed at tests/ root (not tests/driver/, which the unit-test workflow ignores) so it runs in CI; falkordb is installed there via `uv sync --all-extras`. Harvested from getzep#1494 (credit @mturac) and adapted to this PR's BFS rewrite (type(e) guard after rebinding rel -> e). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
|
Thanks for this — your |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoids the FalkorDB edge search re-MATCH pattern that scans
RELATES_TOedges byuuidafter the full-text procedure or BFS path traversal has already produced the relationship.The full-text path now uses the returned relationship directly, and the BFS path filters path relationships to
RELATES_TObefore deriving source/target nodes withstartNode/endNode.Type of Change
Objective
Fix the FalkorDB edge search query shape described in #1272 so edge endpoint lookup is linear in the returned relationships instead of forcing a relationship re-scan by UUID.
Testing
Validation run:
DISABLE_FALKORDB=1 DISABLE_KUZU=1 DISABLE_NEPTUNE=1 uv run pytest tests/driver/test_falkordb_search_ops.pyuv run ruff format graphiti_core/driver/falkordb/operations/search_ops.py tests/driver/test_falkordb_search_ops.py --checkuv run ruff check graphiti_core/driver/falkordb/operations/search_ops.py tests/driver/test_falkordb_search_ops.pygit diff --checkBreaking Changes
Checklist
make lintpasses)Related Issues
Closes #1272