user/edit/password: check strength with zxcvbn - #1745
Draft
alxndrsn wants to merge 2 commits into
Draft
Conversation
Falls back to length-based check if zxcvbn load takes too long (it's massive).
|
alxndrsn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
Falls back to length-based check if zxcvbn load takes too long (it's massive).
Closes #
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
How does this change impact users? Describe intentional behavior changes from code updates. What are the regression risks?
Does this change require updates to user documentation? If so, please file an issue here and include the link below.