Run macOS connect smoke on self-hosted runner

[atavism]

Splits the macOS connect smoke into a dedicated self-hosted CI job. The macOS build still runs on the normal hosted workflow, then the signed app artifact is downloaded and tested on the persistent lantern-macos-smoke runner

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c33c8f7a-8581-47b7-a742-66628b213908

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch atavism/macos-connect-self-hosted

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

This PR splits the macOS connect/disconnect smoke test out of the standard hosted macOS build workflow into a dedicated reusable workflow that runs on a persistent self-hosted macOS ARM64 runner, while the hosted build job produces and uploads a signed app artifact for the smoke job to consume.

Changes:

• Added a new reusable workflow (macos-connect-smoke.yml) that downloads build artifacts and runs the connect smoke suite on a self-hosted runner.
• Updated the macOS build workflow to package and upload Lantern.app.zip as an artifact (and removed the inline connect smoke execution).
• Updated the app smoke test orchestrator to invoke the new macOS connect smoke workflow after the macOS build completes.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
.github/workflows/macos-connect-smoke.yml	New reusable workflow to run macOS connect smoke on a self-hosted runner using downloaded artifacts.
.github/workflows/build-macos.yml	Removes in-build connect smoke; packages and uploads the macOS app as a zipped artifact for downstream smoke testing.
.github/workflows/app-smoke-tests.yml	Adds a dedicated macos-connect-smoke job that depends on the macOS build and calls the new workflow.
.github/scripts/macos_smoke_suite.sh	Enhances app path resolution to support downloaded artifacts (zip/DMG) and improves cleanup behavior.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[jigar-f]

LGTM

[atavism]

Thanks, @jigar-f!!